Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Extracts type definitions from ExtensionsRegistry #24214

Merged
merged 2 commits into from
May 30, 2023
Merged

refactor: Extracts type definitions from ExtensionsRegistry #24214

merged 2 commits into from
May 30, 2023

Conversation

michael-s-molina
Copy link
Member

SUMMARY

This PR extracts types definitions from ExtensionsRegistry to a types.ts file to improve maintainability.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@michael-s-molina michael-s-molina mentioned this pull request May 25, 2023
Merged
9 tasks
@codecov
Copy link

codecov bot commented May 25, 2023

Codecov Report

Merging #24214 (e39e302) into master (9df8d8d) will not change coverage.
The diff coverage is n/a.

❗ Current head e39e302 differs from pull request most recent head cccabb2. Consider uploading reports for the commit cccabb2 to get more accurate results

@@           Coverage Diff           @@
##           master   #24214   +/-   ##
=======================================
  Coverage   68.30%   68.30%           
=======================================
  Files        1957     1957           
  Lines       75594    75594           
  Branches     8224     8224           
=======================================
  Hits        51637    51637           
  Misses      21849    21849           
  Partials     2108     2108
Flag Coverage Δ
javascript 54.72% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...set-ui-core/src/ui-overrides/ExtensionsRegistry.ts 100.00% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Antonio-RiveroMartnez
Antonio-RiveroMartnez approved these changes May 25, 2023
View reviewed changes
Copy link
Member

@Antonio-RiveroMartnez Antonio-RiveroMartnez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! lgtm

@michael-s-molina michael-s-molina merged commit f56c851 into apache:master May 30, 2023
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 3.0.0 labels Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Antonio-RiveroMartnez Antonio-RiveroMartnez Antonio-RiveroMartnez approved these changes

@justinpark justinpark Awaiting requested review from justinpark

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/L 🚢 3.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@michael-s-molina @Antonio-RiveroMartnez @mistercrunch